From 91d40d7eaf07fbc7269cdfee30a62e37c37b696c Mon Sep 17 00:00:00 2001 From: Dirk Alders Date: Mon, 4 Aug 2025 19:34:26 +0200 Subject: [PATCH] Improved behaviour, when not choosing CDDB entry --- media | 2 +- pyripgui.py | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/media b/media index ceece81..bbe327c 160000 --- a/media +++ b/media @@ -1 +1 @@ -Subproject commit ceece81b6d35366f6c365f3b70c3b8c4e63303ff +Subproject commit bbe327c73ba1394302fa364de890046a38dce06b diff --git a/pyripgui.py b/pyripgui.py index ebcfc83..535610b 100644 --- a/pyripgui.py +++ b/pyripgui.py @@ -14,7 +14,6 @@ import sys logger = report.app_logging_config() # TODO: Stop / Kill Threads before close: QThread: Destroyed while thread '' is still running -# TODO: Error handling on cancelling cddb choose Dialog MEDIA_GUI_DICT = { @@ -87,7 +86,6 @@ class RipMainWindow(MainWindow): def read_it(self): self.set_status("Reading data from disc...") disc_data = media.get_media_data(media.get_disc_device(), self.cddb_choose_dialog) - # disc_data = media.metadata.get_disc_data_dummy() if disc_data is None: msg = "Could not read disc data!" logger.error(msg) @@ -112,11 +110,6 @@ class RipMainWindow(MainWindow): dlg = SelectionDialog(self, "Multiple CDDB entries found. Choose one.", values) if dlg.exec(): return keys[dlg.get_selected_index()] - else: - msg = "Invalid cddb selection!" - logger.error(msg) - self.set_status(msg) - QMessageBox.critical(self, "Error!", msg) def get_job_data(self, list_index): list_item = self.list_widget.item(list_index)