Communication adaptions

powerplug.py

@@ -40,7 +40,7 @@ class sispmctl(object):
             try:
                 out_txt = subprocess.check_output(["sudo", "sispmctl", "-o" if state == True else "-f", output]).decode('UTF-8')
             except subprocess.CalledProcessError as grepexc:                                                                                                   
-                logger.error("sispm error code %d", grepexc.returncode)
+                logger.error("sispm error code %d while changing state of channel %s", grepexc.returncode, output)
             else:
                 logger.info('sispmctl channel %s changed to %s', output, state)
                 self.publish_states()
@@ -53,15 +53,19 @@ class sispmctl(object):
             self.set_out_state(output, not self.__state__[int(output) - 1])
 
     def get_out_states(self):
-        try:
-            out_txt = subprocess.check_output(["sudo", "sispmctl", "-g", "all"])
-        except subprocess.CalledProcessError as grepexc:
-            logger.error("sispm error code %d", grepexc.returncode)
-        else:
-            rv = []
-            for i in range(1, 5):
-                rv.append(out_txt.decode("UTF-8").split("\n")[i].split("\t")[1] == "on")
-            return rv
+        i = 0
+        while i < 10:	# number of tries
+            try:
+                out_txt = subprocess.check_output(["sudo", "sispmctl", "-g", "all"])
+            except subprocess.CalledProcessError as grepexc:
+                logger.error("sispm error code %d while getting states", grepexc.returncode)
+            else:
+                rv = []
+                for i in range(1, 5):
+                    rv.append(out_txt.decode("UTF-8").split("\n")[i].split("\t")[1] == "on")
+                return rv
+        logger.warning("Could not get state of powerplugs")
+        return self.__state__
 
     def publish_states(self):
         self.__state__ = self.get_out_states()
@@ -69,35 +73,30 @@ class sispmctl(object):
             self.send_state(i)
 
     def send_state(self, output):
-        topic = config.MQTT_TOPIC + "/status/" + str(output)
-        logger.info("Sending Powerplug status information of plug %s to mqtt %s = %s", str(output), topic, str(self.__state__[output - 1]))
+        topic = config.MQTT_TOPIC + "/output/" + str(output)
+        logger.debug("Sending Powerplug status information of plug %s to mqtt %s = %s", str(output), topic, str(self.__state__[output - 1]))
         try:
             self.__mqtt_client__.send(topic, "true" if self.__state__[output - 1] else "false")
         except (socket.timeout, OSError) as e:
-            logger.warning("Erro while sending state information information")
+            logger.warning("Error while sending state information via mqtt")
 
 
 class mqtt_powerplug(mqtt.mqtt_client):
     def __init__(self):
         mqtt.mqtt_client.__init__(self, config.APP_NAME, config.MQTT_SERVER, 1883, config.MQTT_USER, config.MQTT_PASS)
         for target in ["1", "2", "3", "4", "all"]:
-            self.add_callback(config.MQTT_TOPIC + "/set/" + target, self.__set__)
-            self.add_callback(config.MQTT_TOPIC + "/toggle/" + target, self.__toggle__)
+            self.add_callback(config.MQTT_TOPIC + "/output/%s/set" % target, self.__set__)
         #
         self.__sc__ = sispmctl(self)
 
     def __set__(self, client, userdata, message):
-        output = message.topic.split("/")[-1]
-        if message.topic.find("set") >= 0:
-            state = message.payload == b"true"
-            logger.info("Received request to set output channel %s to state %s", output, str(state))
-            self.__sc__.set_out_state(output, state)
-
-    def __toggle__(self, client, userdata, message):
-        output = message.topic.split("/")[-1]
-        logger.info("Received request to toggle output channel %s", output)
-        if message.payload != b"false":
+        output = message.topic.split("/")[-2]
+        if message.payload == b"true" or message.payload == b"false":
+            self.__sc__.set_out_state(output, message.payload == b"true")
+        elif message.payload.lower() == b'toggle':
             self.__sc__.toggle_out_state(output)
+        else:
+            logger.warning("Ignoring set command due to payload: %s", message.payload)
 
     def __del__(self):
         self.__client__.loop_stop()                                              # stop the loop